Feat: GitHub Actions workflow for linting and tests #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tripledoublev
commented
May 24, 2025
tripledoublev
commented
- clippy fixes
- github action for linting and testing
- new test cleanup method
Update test cases to utilize the new cleanup function for stopping backends and ensure proper synchronization after operations.
There was a problem hiding this comment.
Pull Request Overview
This PR applies Clippy lint fixes, introduces a GitHub Actions workflow for linting and testing, and adds a shared test cleanup helper along with enhanced retry logic for test setup.
- Remove redundant module nesting and fix import paths for
get_backend - Adjust parameter passing for
create_veilid_cryptokey_from_base64and combine nested conditions - Refactor tests to add
wait_for_public_internet_readyandcleanup_test_resources, and update cleanup calls
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server.rs | Flatten module structure by removing pub mod server |
| src/repos.rs | Fix imports for get_backend, remove & on calls, add unused anyhow::Result import |
| src/media.rs | Same import/path fixes as repos, consolidate conditionals, change handler return type |
| src/logging.rs | Use $crate in macro for proper hygiene |
| src/lib.rs | Extensive test refactoring: new helpers, assertions, cleanup |
| src/groups.rs | Fix imports, add explicit type annotation for Vec |
| README.md | Add API endpoint documentation |
| .github/workflows/lint_and_test.yml | New GitHub Actions workflow for Clippy and tests |
tripledoublev
changed the title
tripledoublev
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…dividual tests in parallel
Updated test names and paths for clarity, improved comments for better understanding, and ensured proper synchronization during group creation, file upload, and refresh operations. Enhanced assertions to verify expected outcomes after each refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.